Use explicit mypy error codes in ignore comments and output #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These affect `rest_framework-stubs/compat.pyi` which is using some weird hacks that Ruff and mypy don't really like. * PYI002: If test must be a simple comparison against sys.platform or sys.version_info * PYI026: Use typing_extensions.TypeAlias for type aliases
|
Draft because #496 should be merged first. |
intgr
force-pushed
the
explicit-error-codes
branch
2 times, most recently
from
26f41c4 to
a3acbdf
Compare
intgr
force-pushed
the
explicit-error-codes
branch
from
a3acbdf to
ec28ed7
Compare
intgr
force-pushed
the
explicit-error-codes
branch
from
4376980 to
19aff01
Compare
intgr
added a commit
to intgr/djangorestframework-stubs
that referenced
this pull request
Sep 21, 2025
…ngo#497) * Adds mypy error codes to output (affects tests) * Requires explicit error codes in `# type: ignore` comments, e.g. `type: ignore[assignment]` * Enables suppressed Ruff lint PGH003.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
# type: ignorecomments, e.g.type: ignore[assignment]Related issues